Fix: multiple HTML rendering and crash bugs in PDF exports#68
Draft
Rom1-B wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
It fixes !43955
TypeError crash when exporting Problems or Changes with linked items that lack
serial/otherserialcolumns (e.g. Software, User): fixed by using null-coalescing fallback beforeToolbox::stripTags().Description rendered as a single block in Problem and Change PDFs:
Toolbox::stripTags()was stripping HTML structure beforedisplayText(), which expects HTML. The strip call is removed.Change analysis and plan fields showing raw HTML: fields were embedded in the label argument via
sprintf()instead of being passed as the content argument todisplayText(). Fixed argument placement; also removed ineffectivesetColumnsSize(10, 90)calls beforedisplayText()(which forces 100% internally).Ticket approval comments showing HTML fragments: comment fields were stored with HTML entities not decoded before PDF rendering. Fixed using
html_entity_decode().TODO: same PR on main